Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple forwards separated by | #7

Merged
merged 2 commits into from
Aug 11, 2016
Merged

allow multiple forwards separated by | #7

merged 2 commits into from
Aug 11, 2016

Conversation

kminek
Copy link
Contributor

@kminek kminek commented Aug 10, 2016

@huan
Copy link
Owner

huan commented Aug 11, 2016

great, thanks for your contribute!

could you modify README for this new feature?

@kminek
Copy link
Contributor Author

kminek commented Aug 11, 2016

done

@huan huan merged commit 958d28f into huan:master Aug 11, 2016
@huan
Copy link
Owner

huan commented Aug 11, 2016

awesome, merged. 👍

the docker image on docker hub should be update automaticly, which tagged by latest

@huan
Copy link
Owner

huan commented Aug 28, 2016

@kminek had you tried to use "," support multi destination address?

You can specify multiple forwarding emails by separating them by semicolons. from1@domain:to@target:password;from2@domain:to@target. - https://kiani.io/blog/custom-domain-mail-forward

If "," works, I think "|" is no more needed.

@kminek
Copy link
Contributor Author

kminek commented Aug 28, 2016

if "," works, I think "|" is no more needed

semicolon !== comma :)

i tried from1@domain:to@target;from1@domain:otherto@target but it wasn't working (note that we are talking about mutliple forward addresses for SINGLE from1@domain)

@huan
Copy link
Owner

huan commented Aug 28, 2016

ok. I have neither tried semicolon nor comma, however I feel comma is more natual, because when we send email, we can use comma in "To" or "Cc".

maybe to support "|" and ";" and "," at the same time is a good idea?

@kminek
Copy link
Contributor Author

kminek commented Aug 28, 2016

i picked | because ; and : symbols were already used and performed their role in the process of translating this big string into config file :) but i agree that , is more natural so i'm ok with the switch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants